Loomio

Editing Proposals

Richard D. Bartlett PublicSeen by 106

Aaron Thornton

mmm I would have liked to see the result of the last proposal without it being closed. It seems closing the proposal prematurely is almost as bad as editing it. Once someone votes it seems quite logical to disallow editing from then on.

Joshua Vial

This feels like a micro example of what a multi proposal discussion could look like where individuals take proposals and improve them and people shift their votes to the one that they like the most.

In this case you can see me forking the disable one saying let's disable it after a certain time and then alanna goes and forks that by adding in after someone has voted as well.

I can start to see how fluid and dynamic this could be if it was easy for an individual to click a fork/ammend proposal button and then for users to quickly get an overview of all the proposals on the table.

I can also see how that could scale out to threaded loomios for complex decisions (think writing a piece of legislation)

Benjamin Knight

The time-limited edit proposal function would be a step up from what we have now, but the downside is that it doesn't allow for dynamic proposal-editing through the discussion (which might have actually been pretty useful in this very discussion, rather than closing and re-opening) -

I think changing the proposal in response to new developments in the discussion is an important thing (encouraging the group to end up at a proposal that's better than the one they began with), and that it's only problematic if it's not transparent.

Thoughts?

Richard D. Bartlett

There are two reasons a proposal gets edited:

1) you made a typo
2) the proposal has evolved.

Case 1 is no big deal; it can easily be accommodated by allowing edits only until the first vote has been cast or until a timer runs out.

Case 2 though is way harder to deal with. What does it mean to edit a proposal after someone has already stated their opinion on it? I'm sure there's a place for features like forking, merging, & concurrent proposals to handle Case 2. I think it is going to be a significant challenge to get this working.

The point is, right now I think the feature is worse than nothing. If we disable the edit feature (either entirely or only after the first vote has been cast), then Case 2 is handled by closing the proposal and starting a new one. Proposals are cheap, this seems to be a perfectly logical place to start.

The way it currently works is super bung. Let's say someone's stated position is "No, but I will agree with this if you change X to Y", then once you have edited the proposal they have to come in and change their position. At the same time you've added a question mark to all the Yes's your proposal has already received, so they may have to change their positions too. At the very least they should all be notified. (In many cases you can assume that everyone will agree with you but that is an inherently centralised decision for one person to make.) In other words, it's just as much work to close and start a new proposal as it is to edit one fairly.

The final solution to Case 2 is likely many iterations away. I don't really understand the attachment to the current (IMO) broken feature.

Jon Lemmon

Richard does make a good point. Even sending a notification that the proposal has changed is still problematic. The reason being that, as Richard says, it puts all of the existing positions in an ambiguous state, which is not very fair to the users.

I reckon the 15 minute limit sounds like a good idea for now. And in the future we can think about better ways to deal with this (e.g. forking, etc.).

Jon Lemmon

(i've come around)

Paul Smith

I'm kinda torn between the two, but having read the discussion so far I think disabling after 15 min is the "least worse" option.

It's just going to make proposals really rigid until something forkingish arrives.

Richard D. Bartlett

Think about it this way: in an alternate universe where the 'edit proposal' button didn't exist, if I proposed to add it, everyone would agree it was a dumb idea.

James McCann

Hey guys - hope you don't mind me putting up a few ideas I had while reading through...

Closing a proposal and starting a new one seems to be the most logical option for evolving a "proposal chain" as the discussion drives consensus or other options on an issue (Richard's Case 2 below). Previous votes are still visible and nobody is left with an ambiguous or conflicting vote because the proposal has changed. One possible way to make this more obvious I thought might be helpful would be to bring the previous proposals up as condensed tabs (which can be expanded) underneath the proposals chart but above the individual proposals so the chain of evolution is clearly visible, as well as being viewed without navigating away from the current page.

Editing a proposal before the first vote is cast/15min sounds good for correcting typos as Richard mentioned in Case 1 below.

The forking idea for evolving a proposal rather than editing sounds cool but leads to new questions like 'are two proposals mutually exclusive?', does a yes on proposal one reflect a no on proposal two. In the case here the two proposals in this discussion would be mutually exclusive - making edits more prominent implies that edits are not disabled. This seems like it could be simplified into one proposal with a forked set of options - either make the edits more prominent or disable them altogether.

Matthew Bartlett

When proposals are closed, I'd love to see a little summary appear in the discussion feed. It might list the proposer, the duration, whether it was closed early, and a little pie chart.

Benjamin Knight

@James - awesome to get your input here, please keep it coming! And feel free to encourage others in your group to get involved too!

Danyl Strype

Can I suggest having a list of closed proposals above the current proposal? This gives users a history of what proposals the discussion has produced at a glance, before they start evaluating the new proposal. Even better would be making it an expandable list, where clicking on a closed proposal brings up the contact, pie chart and the positions people took.

James said:

The forking idea for evolving a proposal rather than editing sounds cool but leads to new questions like 'are two proposals mutually exclusive?', <<

Forking proposals would be where they are mutually exclusive, as in this discussion. Where they are not mutually exclusive, it would make more sense to me to fork the discussion, so there is a separate comment thread on each proposal.

This is more "blue skies" thinking from me, but would be cool to have a way to link multiple proposals and/or comments in multiple discussions, to illustrate that they are connected/ dependent on each other in some way.

Aaron Thornton

Agree with Strypey and James that making the closed proposals visible from the top would give added context to the current proposal. Maybe implemented with some sort of tab styling. We have been thinking of adding an icon and count of closed proposals to the previews on the dash also. Seem to be getting into one of those forked discussions being talked about so I will stop.

Jon Lemmon

Sorry for being such a stick in the mud here, but I'm actually still not convinced.

People tend to vote on proposals pretty quickly. So I would imagine that from the time you click "edit proposal", make your changes, and then click "save changes", someone else could very likely have already voted, and the application would stop you from making the changes.

It seems like a really weird flow to be honest -- an interim solution which probably isn't worth the development time.

I've pretty much come full circle around to Rich's perspective. The current functionality is broken. Why don't we axe the feature and it'll put pressure on us to figure out how to implement it correctly? Either that or we leave it as is until we can come up with something that is actually better (instead of just a weird hack).

Jon Lemmon

My main point is... I don't think it's worth the time or effort time code a half-developed feature idea. I think we should flesh this thing out and do it properly. And if we decide that we have to get rid of the button in the meantime I'm okay with that.

Jon Lemmon

(As usual, if the group decides that they want to go along with this proposal for now, I'm happy to defer to the group.)

Alanna Irving

I would go along with simply killing the feature

Benjamin Knight

I love it that the most contentious discussion we've had yet is also one of the least important!

Do people feel it's time to close this proposal down and fire up a brutal feature killing proposal in its place?

I'm very happy to if so!

Benjamin Knight

If we were living in a village setting we'd all be at The Feature's door with pitchforks and flaming torches right now

Paul Smith

I do agree the feature is broken but now that it's there I do want to be able to preview a proposal and have a minute or two to change it, sometimes you just need to add a couple like breaks to make something more readable that's not clear when you're editing a text box.

Even if forking proposals was implemented I think having a few minutes to double check your formatting and spelling is actually good practice.

Jon Lemmon

Hey look, auto-linking doesn't work on apostrophe's! =(

Richard D. Bartlett

Paul how about a 'Preview proposal' button? I reckon we're going to want a Preview Comment button when markdown gets implemented anyway :)

Danyl Strype

+1 Preview buttons.

My suggestions:
* Clicking 'edit proposal' automatically closes the current proposal, and when the edited version is saved, creates a new one
* Move the 'closed proposal' box to the top of the proposal column
* List only closed proposals which at least one person has taken a position on (when proposal is edited to fix typos, improve sense of text etc, the auto-closed proposal is just clutter)

I actually disagree that this discussion is trivial. There's been a lot of good discussion about how the design of Loomio can facilitate productive discussion, and sound decision-making.

Joshua Vial

I'm happy to just kill the feature until something better is ready - if you make a typo just close proposal and copy/paste/edit

Paul Smith

A preview proposal button would definitely be nice, I'm fine with killing the feature short term till we've got a proper solution too.

Regarding the timed edits there could be an option on a new proposal for a 5-15? minute window before it is actionable (you could even delay the notification e-mail being sent), so when a proposal is posted it's in an editable unvotable state for the period of user review.

I also wonder if Papertrail might be good for this, could have like version controlled Proposals... on second thought it's probably overkill again but worth mentioning.

The edit button does seem trivial but I think it hits an underlying question of discussion/proposal authenticity vs user experience.

Aaron Thornton

I am liking this idea of Pauls now. I feel we should not do a quick fix and think that a good solution is not that far away. We have some good ideas here and are best to nail it while this is all current. I am changing my position to abstain on this proposal in favor of a new proposal based on a non-actional window where the proposal can be talked about in the discussion and editable by the author.