Tweak: do not trigger "unread" when closing thread
After I close a thread, it says "unread" so I need to open it again to remove that notification. Would be nice to not do that, and just leave it read, since closing thread = no longer relevant.
My gut says to update existing readers, but my mind says we want to modify update_sequence_info! to not include some blacklisted event kinds. If they don't appear in the ranges_string field on discussion, we shouldn't have unread troubles I don't think.
Yea, my feeling is we update existing readers as if they did read the events, rather than doing anything more complex. Then the events look unread to people who are just reading them for the first time.
Agreed!
One way to implement this is another set of ranges on the discussion, something like consider_as_read_ranges or ignored_ranges or something, which get mixed into the read ranges when we compute the unread count. Then when you create a closed event you add it to the set of ranges which should be computed as already read by everyone.
Another way is to just update all the existing discussion readers and mark that sequence id as read.
I'm not sure which is better.