Search

Awesome. That looks good to me. Interested to see the results page.

One thing to think about... are we just going to be searching through both proposals and discussions for now, or just discussions?

If both, we'll need a way of distinguishing between proposals and discussions on the results page.

So keen for this feature, I lose discussions all the time and quite often can't even remember which subgroup I'm looking through to find them haha.

For the results page I'd really like to see it just ajax filter on the dashboard so as you're typing in your search string the list of discussions is clearing out the ones that don't match. Would give users heaps more control at the dashboard level.

Would be great to have it search through proposal titles as well - but discussion titles only would still be a great place to start if it's simpler

I like it! in the future can we have advanced search where you can search only in the title, only in certain groups/subgroups, or search by author, etc?

@alanna - in the future we can have everything!

Flying cars! Electric cucumbers! Gyroscopic feather dusters!

Bump - is anyone currently working on this? I've been pretty busy lately but I'd like to get back onto this one!

@jonlemmon I was hoping to break this task up, firstly doing something like the above mockup which just does a simple filtering on the discussions list using a query str to match on the title (very similar to @mentions). Following that, implementing a full text search with a results page etc. would be the next step. Thoughts?

@jamesmccann that sounds like a great place to start to me!

If you're feeling keen, maybe try to build it outside-in with cucumber tests. Also might be a good idea to submit a pull-request early on (before you've completed it) and mention me along the way while you're building it and I can help guide you through the process wherever you run into any snags.

Also, I reckon let's try to really sort out the spec before you start building it. So what I'm imagining is...

• You start typing in the search box and it autocompletes
• It should display a max of maybe 10 discussions
• It should show a date the discussion was last posted to as well
• Just start with search on the group page for now (and leave the dashboard till later)

Does this sound right to you? Whatever you're imagining for the behaviour, can you post a mockup of it (perhaps using balsamiq)?

@jonlemmon Sweet as, I'll chuck down my thoughts so far.

Here's a quick "mockup" of what I've got so far, sorry was easier to do it this way than in balsamiq.
https://docs.google.com/file/d/0B4_HCol896iTdXVmTGpIaHNHWjA/edit

Basically the discussions list will be filtered against the search term on the discussion titles. So a commonly used word might still bring up multiple pages encouraging the user to be more specific. This is just an assumption that discussion titles would be the most common things searched for.

Looking ahead I was thinking a similar UI to above but with an extra search button (like the mockup here https://docs.google.com/open?id=0B4_HCol896iTOFVycmp1QXBoNFE) which will link to a "full text" discussion, context, motion, comments search with a new results page.

Let me know what you think.

Nice! @jonlemmon do you think it will be significantly easier to limit the feature to just the group page? It would be really nice to have it on the dashboard...

@richarddbartlett From the way I have seen it so far either group page or dashboard page will be fine as it just applies a filter after the list of discussions has been created.

@jamesmccann @richarddbartlett sweet, I think you guys are right that it should work fine for either page (dashboard or group).

@jamesmccann thanks for the mockup. So I assume those results only display upon clicking the search button (and not filtering as you type)?

And just as a point-of-process - we've found that it's really useful to describe all of the actions that the user has to take within the mockup itself (e.g. "user types in 'other' into this search box, clicks the search button, and sees the results on slide #2") It might sound pedantic, but it makes understanding & agreeing upon a feature way easier.

@jonlemmon Yeah good idea re: descriptions on the mockup. To answer the question in this instance I had actually thought it would be nice to have live filtering as you type.

The search button would take you to a results page which has more detailed results (i.e. searches comments etc not only titles).

I guess this effectively means the initial filtering of the discussions list is the same as displaying a dropdown auto-complete box underneath the search field.

Sorry if its not clear - maybe I'll come down after work and show you what I've got?

p.s. not sure if anyone has reported this but I get two notifications for being mentioned twice in your below comment? If this is a known bug I can look at fixing it as well.

Good spotting on the bug @jamesmccann, I've added it to a related card on trello.

Personally I tend to agree with your suggestion for live-filtering in a dropdown, with the search button taking you to a detailed results page. Come visit us anyway :)

this has been suggested as potentially interesting
http://harvesthq.github.com/chosen/

zone searches :
site wide vs. only in group/subgroup

I have already fixed that bug.

@aaronthornton are you sure? this is a slightly different one. it's if a user get's mentioned twice in one comment.

i'm pretty sure that the bug you fixed was a user getting notified twice when they get mentioned once in a comment.

It might be a slightly different bug? Unless its been fixed and waiting to be deployed?

I've got a pull request here https://github.com/enspiral/loomio/pull/449 that should fix this along with the double up for a new comment/mentioned notification bug - both on this card https://trello.com/card/new-comment-and-mentioned-you-in-a-comment-notifications-should-be-collapsed-into-one/4fc418d7b528e7e2398311b4/359

My bad. At least we have it covered now.

Can anyone tell me the progress on this feature? @jamesmccann @jonlemmon

See here https://github.com/jamesmccann/loomio/tree/feature/filter-search

Sorry I mentioned Jon in this branch to comment on it but he might not get notifications from my repo? I should have pull requested it.

Anyway, I've refactored as per me and Jon's sit down the other day. If Jon has a look and gets back to me with his thoughts/check over what I've done with the DiscussionsQuery so far then I can finish this off.

@jamesmccann I think I might have responded to your at-mention. Are you talking about this one?

https://github.com/jamesmccann/loomio/commit/6f908013e832f25c9db21c68f297c47f1ede4328

Sorry, I should have double-checked to see that you got my message. Github notifications seem to be a bit strange sometimes.

=)

@jonlemmon true! Weird I didn't see any Github or Loomio notifications in my email. My bad. I'll suss this one out asap

@jamesmccann no worries. I find GH notifications a bit hard to keep track of myself.

@jonlemmon yeah not the best eh. Finally got some internet at my new flat so I'll sort this over this coming weekend!

@jamesmccann rad. I'll be away for the weekend but will have a look when I'm back on Monday or Tuesday.

@jonlemmon @richarddbartlett I've made a pull request for this feature now. Hopefully it is all looking OK. The JS code is not the best... I would definitely want to refactor it at some stage whether in this request or another one.

At the current stage I've only tested it with my local database - might need testing on a larger one.

Nice! Awesome to have this feature James. Works like a charm. Are the current motions still suppose to be there? I reakon is would look slicker if they waren't, but no biggy (I could get rid of them later on if your too busy) this feature rocks, it adds so much to the app.

@jamesmccann Awesome!! Looking forward to checking it out.

I agree with Aaron that current motions should be cleared when the search is active.

@aaronthornton @jonlemmon - sweet, latest commit should fix that. Wasn't sure about those failing specs are they unrelated?

@jamesmccann yeah those spec have been floating around for awhile now. I just submitted a pull request that should sort them out, @jonlemmon can you merge this.